Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title and H1 not announcing on confirmation loader or page #3665

Closed
4 of 5 tasks
srtalbot opened this issue May 17, 2024 · 14 comments
Closed
4 of 5 tasks

Title and H1 not announcing on confirmation loader or page #3665

srtalbot opened this issue May 17, 2024 · 14 comments
Assignees
Labels
a11y Accessibility related issue App bug Something isn't working design Design task / work required 🚦 Critical Critical Impact Issue - Show stopper

Comments

@srtalbot
Copy link
Contributor

srtalbot commented May 17, 2024

Previously we were setting the H1 on the confirmation page so that clients building forms could not update it and there would always be a consistent announcement for screen reader users.

Neither the Title nor H1 are set, focused, or announced for confirmation pages. Here is a test form on production.

image.png

Acceptance criteria:

  • Provide a set title or H1 for screen reader users that announces the form submission is complete.
  • The announcement must be generic so that it will apply to any type of form (e.g., a survey, an application, a service, etc.)
  • Announce the loader that comes while the form is being submitted.
  • Identify when the regression came in
  • Identify an automated testing plan to prevent future regressions.
@srtalbot srtalbot added a11y Accessibility related issue 🚦 Critical Critical Impact Issue - Show stopper bug Something isn't working app router App labels May 17, 2024
@timarney
Copy link
Member

timarney commented May 17, 2024

@srtalbot
Copy link
Contributor Author

srtalbot commented May 21, 2024

Options

  1. Create a H1 field in the form builder
  2. Set H2s on existing forms to an H1
  3. Provide an automatic Title

Option 3:

  • Review the code to provide a generic "confirmation" message that is NOT "Thank you for your submission"
  • Add a consistent title to every confirmation page.
  • How to we display "Your submission has been received" for the gov-user in the form builder?
  • Add the text in "test" view as well.
  • Slight down-side: There may be some duplication of content if the form builder has added the same message in the body of their text.
  • Review the existing form templates to search for this text in existing forms on their confirmation page.
  • Check how many forms even have an H2

@samsadasivan samsadasivan added the design Design task / work required label May 22, 2024
@thiessenp-cds thiessenp-cds self-assigned this May 22, 2024
@samsadasivan
Copy link
Contributor

PROPOSAL: Default confirmation message.

For the confirmation message, we can make it visually explicit or as a descriptor in the card itself. The Review page is the only element that is similar.

Review page:

  • no editable content, therefore there is no way to interact with it in the /Translation page and /Question page, but you can view in the /Logic page

Confirmation page:

  • has editable content, but with the title being default or locked. You can't remove it and its not its "own" rich text card.

We can either design it to be explicit or implicit.

Explicit:

  • Visually represented in the card, using the tag component (similar to the tags in /Forms)
  • Doesn't show up in the /Translation view
  • Shows up in the /Logic view within the "End" Section

Implicit

  • Added as part of the descriptor to the current confirmation message card
  • Not a part of /Translation view
  • Not a part of /Logic view

@samsadasivan
Copy link
Contributor

Explicit:

image.png

image.png

@samsadasivan
Copy link
Contributor

Implicit:
image.png

@samsadasivan
Copy link
Contributor

image.png

@samsadasivan
Copy link
Contributor

Update :)

image.png

@samsadasivan
Copy link
Contributor

image.png

@samsadasivan
Copy link
Contributor

EN: Your form has been submitted --- Section title
FR: Votre formulaire a été soumis --- Titre de la section

@samsadasivan samsadasivan self-assigned this May 23, 2024
@timarney timarney self-assigned this May 23, 2024
@samsadasivan
Copy link
Contributor

samsadasivan commented May 23, 2024

SORRY - Work can be found under the CL file

Conditional Logic MVP/ 🟡 Right panel (dev test)/ Section: Monday May 21 notes -> "Title and H1 not announcing on confirmation loader or page"

@timarney
Copy link
Member

Note:

We had a cypress test in place to detect that the H1 was present.

Screenshot 2024-05-24 at 9 38 51 AM

✅ The test was passing

But ...

The fixture data wasn't accurate. Forms published using the builder don't allow confirmation to be empty.


The fixture data used by the test has empty strings.

Screenshot 2024-05-24 at 9 37 53 AM

@timarney
Copy link
Member

Merged to staging.

@timarney timarney removed their assignment May 24, 2024
@Abi-Nada Abi-Nada self-assigned this May 27, 2024
@Abi-Nada
Copy link

@Abi-Nada and @samsadasivan to test and confirm

@Abi-Nada
Copy link

Tested and can be closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility related issue App bug Something isn't working design Design task / work required 🚦 Critical Critical Impact Issue - Show stopper
Projects
None yet
Development

No branches or pull requests

5 participants