Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 4.1 #566

Closed
carlosdorneles-mb opened this issue Aug 3, 2022 · 17 comments
Closed

Add support for Django 4.1 #566

carlosdorneles-mb opened this issue Aug 3, 2022 · 17 comments

Comments

@carlosdorneles-mb
Copy link

First, Thanks for this great project! 馃憤

Summary:
Current django-celery-beat requires Django (>=3.2.13,<4.1) and hence doesn't install together w/ Django 4.1.

@auvipy
Copy link
Member

auvipy commented Aug 4, 2022

will relax the requirement and try to push a new release

@awemulya
Copy link

awemulya commented Aug 5, 2022

+1

@Olerdrive
Copy link

Any updates?

@auvipy
Copy link
Member

auvipy commented Aug 15, 2022

work in progress #567

@boatcoder
Copy link

I'm going to do the same on the testing front

@Crocmagnon
Copy link

Crocmagnon commented Oct 7, 2022

Is there still something preventing django-celery-beat from supporting Django 4.1?

@goatwu1993
Copy link
Contributor

goatwu1993 commented Oct 11, 2022

Django 4.1 support is merged into the master branch at #567
I believe the only thing left is a new release.

@auvipy anything I can help with for a new release?

@rbarsegi
Copy link
Contributor

Please merge #589 to allow support for Django 4.1

@carlosdorneles-mb
Copy link
Author

@rbarsegi PR #589 is not needed as PR #567 is already merged and it supports Django 4.1. We are just waiting for the generation of a new version of the code that is in the master.

@rbarsegi
Copy link
Contributor

rbarsegi commented Oct 11, 2022

@carlosdorneles-mb #567 only updated test requirements from what I can tell. Install requirements are still behind (see the diffs in my PR). If you try to install from master branch right now it will downgrade Django to 4.0.x.

@auvipy
Copy link
Member

auvipy commented Oct 12, 2022

#581 can anyone check the python 3.7 failures?

@goatwu1993
Copy link
Contributor

goatwu1993 commented Oct 12, 2022

@auvipy Upstream error by kombu & celery, caused by using importlib-metadata API which is deprecated at 5.0.0

Both libs have been fixed and merged but in 5.3.0 milestone.

celery/kombu#1601
celery/celery#7785

Only python < 3.8 needs importlib-metadata, which is why only python37 breaks here.

open #591 to prove.

@goatwu1993
Copy link
Contributor

goatwu1993 commented Oct 13, 2022

@auvipy please release a version for django 4.1 support, which has multiple cve fixed.

Would be glad to help if anything lack.

@auvipy
Copy link
Member

auvipy commented Oct 13, 2022

yeah going to

@utapyngo
Copy link

yeah going to

What is the estimate release date?

@auvipy
Copy link
Member

auvipy commented Oct 19, 2022

released https://github.com/celery/django-celery-beat/releases/tag/v2.4.0 please try and report bugs

@auvipy auvipy closed this as completed Oct 20, 2022
@JamesonNetworks
Copy link

released https://github.com/celery/django-celery-beat/releases/tag/v2.4.0 please try and report bugs

Thanks for all that you all do! We appreciate ya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants