Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Cannot update to latest jaeger client #19

Open
someone1 opened this issue Jul 1, 2021 · 1 comment
Open

Cannot update to latest jaeger client #19

someone1 opened this issue Jul 1, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@someone1
Copy link

someone1 commented Jul 1, 2021

When trying to update my go deps, I get the following:

# contrib.go.opencensus.io/exporter/jaeger
/go/pkg/mod/contrib.go.opencensus.io/exporter/jaeger@v0.2.1/agent.go:76:10: a.client.SeqId undefined (type *agent.AgentClient has no field or method SeqId)
/go/pkg/mod/contrib.go.opencensus.io/exporter/jaeger@v0.2.1/agent.go:77:30: not enough arguments in call to a.client.EmitBatch
        have (*jaeger.Batch)
        want (context.Context, *jaeger.Batch)
/go/pkg/mod/contrib.go.opencensus.io/exporter/jaeger@v0.2.1/jaeger.go:361:21: not enough arguments in call to obj.Write
        have (*thrift.TBinaryProtocol)
        want (context.Context, thrift.TProtocol)

I have to add the following to keep things happy, but I guess there was a breaking change in the v2.29 update?

replace github.com/uber/jaeger-client-go v2.29.1+incompatible => github.com/uber/jaeger-client-go v2.28.0+incompatible
@mamh2021
Copy link

mamh2021 commented Nov 7, 2022

same error.

# contrib.go.opencensus.io/exporter/jaeger
/home/mamh/.go/pkg/mod/contrib.go.opencensus.io/exporter/jaeger@v0.2.1/agent.go:76:11: a.client.SeqId undefined (type *agent.AgentClient has no field or method SeqId)
/home/mamh/.go/pkg/mod/contrib.go.opencensus.io/exporter/jaeger@v0.2.1/agent.go:77:31: not enough arguments in call to a.client.EmitBatch
        have (*"github.com/uber/jaeger-client-go/thrift-gen/jaeger".Batch)
        want (context.Context, *"github.com/uber/jaeger-client-go/thrift-gen/jaeger".Batch)
/home/mamh/.go/pkg/mod/contrib.go.opencensus.io/exporter/jaeger@v0.2.1/jaeger.go:361:22: not enough arguments in call to obj.Write
        have (*thrift.TBinaryProtocol)
        want (context.Context, thrift.TProtocol)
Makefile:27: recipe for target 'build-linux' fail


add replace github.com/uber/jaeger-client-go v2.30.0+incompatible => github.com/uber/jaeger-client-go v2.28.0+incompatible

	contrib.go.opencensus.io/exporter/jaeger v0.2.1 // indirect
	         github.com/uber/jaeger-client-go v2.25.0+incompatible

	github.com/jaegertracing/jaeger v1.35.2 // indirect
         	github.com/uber/jaeger-client-go v2.30.0+incompatible // indirect

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants