Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Add an option OnExport to exporter #279

Open
yegle opened this issue Dec 11, 2020 · 0 comments · May be fixed by #280
Open

Add an option OnExport to exporter #279

yegle opened this issue Dec 11, 2020 · 0 comments · May be fixed by #280

Comments

@yegle
Copy link
Contributor

yegle commented Dec 11, 2020

NB: Before opening a feature request against this repo, consider whether the feature should/could be implemented in exporter libraries in other languages. If so, please open an issue on opencensus-specs first.

Please let me know if you are OK with this feature. I can send a PR to implement it.

Is your feature request related to a problem? Please describe.
We use OnError to log a line when the exporter failed to export to Stackdriver. This way we can generate a log based alert when the error rate increases.

The problem with this approach is that each replica of our service is exporting and they all can spontaneously fail. If our service scales up, the error rate may naturally go up.

It would be great if we can have an OnExport option, so we can also log when the export succeeded. This way we can calculate an error ratio metric and alert on it.

Describe the solution you'd like
An OnExport option to the Exporter, with a single error argument that could be nil indicating a successful export.

Describe alternatives you've considered
None that I know of.

Additional context
Add any other context or screenshots about the feature request here.

@yegle yegle linked a pull request Dec 11, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant