Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Split core SDK and grpc extensions into new repo #386

Open
curtpm opened this issue Sep 10, 2019 · 0 comments
Open

Split core SDK and grpc extensions into new repo #386

curtpm opened this issue Sep 10, 2019 · 0 comments

Comments

@curtpm
Copy link

curtpm commented Sep 10, 2019

I think its a little confusing and weird to have a cyclic dependency between gRPC and this repo:

https://github.com/census-instrumentation/opencensus-cpp/blob/master/bazel/deps.bzl#L23

https://github.com/grpc/grpc/blob/master/bazel/grpc_deps.bzl#L194

it seems like this repo should be split into a "Core" part and at least one or more repos that depend on only the "gRPC" repo that would also import the Core opencensus SDK

https://github.com/census-instrumentation/opencensus-cpp/tree/master/opencensus/common/internal/grpc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant