Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Made public traceparent/tracestate marshal/unmarshal #1218

Merged
merged 3 commits into from Jul 16, 2020
Merged

Made public traceparent/tracestate marshal/unmarshal #1218

merged 3 commits into from Jul 16, 2020

Conversation

slinkydeveloper
Copy link
Contributor

Fix #1208

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Copy link
Collaborator

@james-bebbington james-bebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should ideally also add (or update the existing) tests to validate the new functions work as expected since they are going to be exported.

plugin/ochttp/propagation/tracecontext/propagation.go Outdated Show resolved Hide resolved
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper requested review from james-bebbington and removed request for a team July 14, 2020 07:09
@james-bebbington james-bebbington merged commit 3456e1d into census-instrumentation:master Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ochttp public traceparent/tracestate marshal/unmarshal
3 participants