Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

feat: Allow users to specify a metric display name prefix #2050

Merged
merged 1 commit into from Aug 11, 2020

Conversation

OmerLitov
Copy link
Contributor

Allow users to specify a metric display name prefix, separately from the metric name prefix

@OmerLitov
Copy link
Contributor Author

this is the implementation for #2040

@nilebox
Copy link
Contributor

nilebox commented Aug 9, 2020

Thanks @OmerLitov, could you please trigger the build again, looks like one of the tests failed due to connectivity issue with Maven Central.
e.g.

git commit --amend --no-edit
git push origin --force

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020

Codecov Report

Merging #2050 into master will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2050      +/-   ##
============================================
- Coverage     83.06%   83.06%   -0.01%     
  Complexity     2251     2251              
============================================
  Files           319      319              
  Lines         10529    10532       +3     
  Branches       1048     1049       +1     
============================================
+ Hits           8746     8748       +2     
  Misses         1446     1446              
- Partials        337      338       +1     
Impacted Files Coverage Δ Complexity Δ
...ats/stackdriver/StackdriverStatsConfiguration.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...ts/stackdriver/CreateMetricDescriptorExporter.java 75.32% <66.66%> (-0.68%) 12.00 <0.00> (ø)
...er/stats/stackdriver/StackdriverStatsExporter.java 70.73% <100.00%> (+0.36%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be7044...523c845. Read the comment docs.

@nilebox nilebox merged commit bd852ef into census-instrumentation:master Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants