Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Add Support for Opencensus to OpenTelemetry migration #2059

Merged

Conversation

zoercai
Copy link
Contributor

@zoercai zoercai commented Oct 14, 2020

Branched off @nilebox changes here: nilebox#1

Declare the ContextManager interface which allows for overriding the context storage in OpenCensus.
Default implementation keeps backward compatible behaviour using gRPC context with OpenCensus-specific key.

Added reflection for OpenTelemetry trace component which will be in the migration library.

@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@zoercai zoercai marked this pull request as ready for review October 19, 2020 10:59
@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #2059 into master will increase coverage by 0.03%.
The diff coverage is 95.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2059      +/-   ##
============================================
+ Coverage     83.05%   83.08%   +0.03%     
- Complexity     2249     2264      +15     
============================================
  Files           319      322       +3     
  Lines         10526    10557      +31     
  Branches       1048     1048              
============================================
+ Hits           8742     8771      +29     
- Misses         1446     1448       +2     
  Partials        338      338              
Impacted Files Coverage Δ Complexity Δ
.../java/io/opencensus/trace/unsafe/ContextUtils.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
api/src/main/java/io/opencensus/trace/Tracing.java 95.23% <75.00%> (-4.77%) 7.00 <1.00> (ø)
...io/opencensus/trace/unsafe/ContextHandleUtils.java 90.90% <90.90%> (ø) 5.00 <5.00> (?)
...ain/java/io/opencensus/trace/CurrentSpanUtils.java 88.88% <100.00%> (+0.20%) 6.00 <1.00> (ø)
.../io/opencensus/trace/unsafe/ContextHandleImpl.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
...io/opencensus/trace/unsafe/ContextManagerImpl.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)
...ontrib/logcorrelation/log4j2/ContextDataUtils.java 88.00% <100.00%> (ø) 8.00 <1.00> (ø)
...on/stackdriver/OpenCensusTraceLoggingEnhancer.java 86.36% <100.00%> (ø) 12.00 <1.00> (ø)
.../sleuth/v1x/OpenCensusSleuthSpanContextHolder.java 81.25% <100.00%> (+0.39%) 17.00 <0.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab6382...cfd0ab2. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants