This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
Fix time skew exceptions crashing disruptor thread #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
requested review from
dinooliva,
rghetia,
songy23 and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2071 +/- ##
============================================
- Coverage 83.08% 83.06% -0.02%
Complexity 2264 2264
============================================
Files 322 322
Lines 10557 10565 +8
Branches 1048 1049 +1
============================================
+ Hits 8771 8776 +5
- Misses 1448 1451 +3
Partials 338 338
Continue to review full report at Codecov.
|
aabmass
reviewed
Jan 7, 2021
impl_core/src/main/java/io/opencensus/implcore/stats/MutableViewData.java
Outdated
Show resolved
Hide resolved
impl_core/src/main/java/io/opencensus/implcore/stats/MutableViewData.java
Show resolved
Hide resolved
punya
approved these changes
Jan 8, 2021
aabmass
approved these changes
Jan 8, 2021
jsuereth
added a commit
to jsuereth/opencensus-java
that referenced
this pull request
Jan 11, 2021
…ation#2071) * Add a fix to metric views when a time skew is detected rather than crashing the application/thread. * Add test for time-rewind issues, and fix problems discovered.
jsuereth
added a commit
that referenced
this pull request
Jan 11, 2021
) * Fix time skew exceptions crashing disruptor thread (#2071) * Add a fix to metric views when a time skew is detected rather than crashing the application/thread. * Add test for time-rewind issues, and fix problems discovered. * Mark ContextUtils as public (but deprecated) (#2072) * Mark ContextUtils as public (but deprecated) to fix bincompat issues with 0.17.x->0.18.x * Add an access mechanism for grpc context and update deprecation denotation. * Update changelog with latest releases.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we fix all known issues with time skew in Metric Views.
MutableViewDatato ensure it does not throw when time rewinds, but instead drops recorded data points and resets itself.Fixes #2068 (deemed to not have a workaround)