Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Mark ContextUtils as public (but deprecated) #2072

Merged
merged 6 commits into from Jan 11, 2021

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Jan 7, 2021

Fixes #2069 - bincompat issues with 0.18.0->0.18.1

@google-cla google-cla bot added the cla: yes label Jan 7, 2021
@gfelbing
Copy link

gfelbing commented Jan 8, 2021

Thanks @jsuereth. To ease the migration of grpc-java to use the ContextHandle, would it be possible to add the io.opencensus.trace.unsafe.ContextHandleImpl#getContext to the io.opencensus.trace.ContextHandle interface?

@jsuereth
Copy link
Contributor Author

jsuereth commented Jan 8, 2021

@gfelbing I'm not going to expose an unsafe API in the old stable ContextHandle, but I can give you a helper method from ContextUtils which will give you access to it. Fixing some tests, will post shortly.

@jsuereth jsuereth merged commit 7ddc4cc into census-instrumentation:master Jan 11, 2021
@jsuereth jsuereth deleted the wip-fix-bincompat branch January 11, 2021 16:10
jsuereth added a commit to jsuereth/opencensus-java that referenced this pull request Jan 11, 2021
…2072)

* Mark ContextUtils as public (but deprecated) to fix bincompat issues with 0.17.x->0.18.x
* Add an access mechanism for grpc context and update deprecation denotation.
jsuereth added a commit that referenced this pull request Jan 11, 2021
)

* Fix time skew exceptions crashing disruptor thread (#2071)

* Add a fix to metric views when a time skew is detected rather than crashing the application/thread.
* Add test for time-rewind issues, and fix problems discovered.

* Mark ContextUtils as public (but deprecated)  (#2072)

* Mark ContextUtils as public (but deprecated) to fix bincompat issues with 0.17.x->0.18.x
* Add an access mechanism for grpc context and update deprecation denotation.

* Update changelog with latest releases.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opencensus 0.28.1 breaks gRPC
3 participants