Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Cannot install on Node 13, grpc dependency needs updating #715

Closed
lovrop opened this issue Nov 28, 2019 · 3 comments
Closed

Cannot install on Node 13, grpc dependency needs updating #715

lovrop opened this issue Nov 28, 2019 · 3 comments
Labels

Comments

@lovrop
Copy link

lovrop commented Nov 28, 2019

What version of OpenCensus are you using?

0.0.19

What version of Node are you using?

13

What did you do?

Full repro steps:

$ node --version
v13.1.0
$ npm --version
6.12.1
$ uname -mrsv
Darwin 18.7.0 Darwin Kernel Version 18.7.0: Tue Aug 20 16:57:14 PDT 2019; root:xnu-4903.271.2~2/RELEASE_X86_64 x86_64
$ mkdir opencensus-repro && cd opencensus-repro
$ npm init -y
$ npm install --save-dev @opencensus/nodejs
... blows up with a C++ compile error

Additional context

The grpc package seems to break regularly with new Node releases but they usually fix it within a few days. The most recent instance was grpc/grpc-node#1086.

Please upgrade the grpc dependency to at least 1.24.2 and, due to the nature of the dependency, consider making it a caret dependency so that there's not a chain of packages that need updating every time. Thanks!

Related: #64

@lovrop lovrop added the bug label Nov 28, 2019
@lovrop
Copy link
Author

lovrop commented Jan 27, 2020

@mayurkale22 sorry for the direct ping but is this something you could take care of quickly, or at least chime in on? It seems straightforward to fix and has been a cause of dependency mini-hell for us for a while now. Thanks! 🙏

@zoidyzoidzoid
Copy link

There is an MR that fixes this #655

@mayurkale22
Copy link
Member

Published in 0.0.20, Feel free to reopen the issue if there's something that #750 doesn't solve.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants