Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

fix(resources): GKE pod name label #728

Merged
merged 1 commit into from Feb 19, 2020

Conversation

mayurkale22
Copy link
Member

Resolves #727

These changes have all been tested locally against a real GKE and Stackdriver instance and been confirmed to be working.

@mayurkale22
Copy link
Member Author

/cc @fiws please review

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #728 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #728      +/-   ##
=========================================
+ Coverage   95.36%   95.4%   +0.04%     
=========================================
  Files         147     148       +1     
  Lines       10684   10694      +10     
  Branches      798     801       +3     
=========================================
+ Hits        10189   10203      +14     
+ Misses        495     491       -4
Impacted Files Coverage Δ
test/test-zipkin.ts 92.3% <0%> (-5.41%) ⬇️
test/test-detect-resource.ts 99.05% <0%> (-0.01%) ⬇️
src/binary-format.ts 100% <0%> (ø) ⬆️
src/grpc-stats/server-stats.ts 100% <0%> (ø) ⬆️
src/object.ts 100% <0%> (ø) ⬆️
src/grpc-stats/client-stats.ts 100% <0%> (ø) ⬆️
test/test-prometheus-stats.ts 100% <0%> (ø) ⬆️
src/grpc-stats/stats-common.ts 100% <0%> (ø) ⬆️
src/grpc-stats/common-distributions.ts 100% <0%> (ø)
src/resource-utils.ts 91.46% <0%> (+1.1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111d29c...86b3752. Read the comment docs.

@fiws
Copy link

fiws commented Jan 9, 2020

@mayurkale22 Thanks for addressing my issue. This looks like it solves my problem.

Edit: i thought the hostname would be the only source for the pod now. i did not correctly read the code ... everything is fine

@miguelgarcia
Copy link

Hello, I'm running into this issue and @mayurkale22 's code does indeed fix the problem. Any hint about when it will be merged ? Thanks a lot!

@mayurkale22
Copy link
Member Author

@draffensperger Please review when you get a chance.

@mayurkale22
Copy link
Member Author

Hello, I'm running into this issue and @mayurkale22 's code does indeed fix the problem. Any hint about when it will be merged ? Thanks a lot!

Sorry for the delay, waiting for PR to get approved. I will include this in 0.0.20 release (#754).

@mayurkale22 mayurkale22 merged commit 2c40254 into census-instrumentation:master Feb 19, 2020
@mayurkale22 mayurkale22 deleted the gkr_resource branch February 19, 2020 03:30
@mayurkale22
Copy link
Member Author

Hello, I'm running into this issue and @mayurkale22 's code does indeed fix the problem. Any hint about when it will be merged ? Thanks a lot!

Published in 0.0.20, let us know if you encounter any issues!

@miguelgarcia
Copy link

Working as expected by now, thanks !

@mayurkale22
Copy link
Member Author

Working as expected by now, thanks !

Ok great, thanks for the confirmation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exporter/stackdriver: GKE pod name label incorrect
6 participants