chore: update dependency grpc to 1.24.2 #750
Conversation
|
This is based on #715, @draffensperger and @lovrop please review |
| @@ -67,7 +67,7 @@ | |||
| "dependencies": { | |||
| "@opencensus/core": "^0.0.19", | |||
| "@opencensus/propagation-binaryformat": "^0.0.19", | |||
| "grpc": "~1.21.0", | |||
| "grpc": "1.24.2", | |||
There was a problem hiding this comment.
^1.24.2 would be more flexible and IMO fit better due to the nature of the dependency (per the Additional context section on #715). Did you intentionally choose an exact version match?
|
Looks good to me, thanks for the tweak. Seems @draffensperger needs to sign off? |
|
@draffensperger Please review when you get a chance. |
| @@ -546,7 +546,7 @@ describe('GrpcPlugin() ', function() { | |||
| grpcModule.status.OK | |||
| ); | |||
| if (method.method === grpcClient.unaryMethod) { | |||
| assertStats(testExporter, 170); | |||
| assertStats(testExporter, 188); | |||
There was a problem hiding this comment.
Out of curiosity, why are the numbers changing here? Will that confuse users at all?
There was a problem hiding this comment.
The latest gRPC release (grpc@1.24.2) added new options (flags) to Metadata class due to this size of bytes send increased a little bit (we measure the sent_bytes_per_rpc).
Proposal: https://github.com/grpc/proposal/blob/master/L48-node-metadata-options.md
PR: grpc/grpc-node#796
mayurkale22
force-pushed
the
grpc_1.24.2
branch
from
a78335a
to
ca58dca
Compare
No description provided.