Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Dependency on deprecated continuation-local-storage #792

Open
oleg-codaio opened this issue Apr 10, 2020 · 3 comments · May be fixed by #793
Open

Dependency on deprecated continuation-local-storage #792

oleg-codaio opened this issue Apr 10, 2020 · 3 comments · May be fixed by #793
Labels

Comments

@oleg-codaio
Copy link

Please answer these questions before submitting a bug report.

What version of OpenCensus are you using?

Latest (https://github.com/census-instrumentation/opencensus-node/blob/master/packages/opencensus-core/package.json has a dependency on CLS)

What version of Node are you using?

v12

What did you do?

Using pm2 (https://pm2.keymetrics.io/), which depends on @opencensus/core internally.

What did you expect to see?

No deprecation warnings.

What did you see instead?

The following warning:

DeprecationWarning: Socket.prototype._handle is deprecated

coming from continuation-local-storage's use of async-listener, which polyfills a removed API with another deprecated API. This package should be migrated to use cls-hooked instead, which uses supported async hooks APIs.

Additional context

Migration should be trivial.

@mayurkale22
Copy link
Member

If you are feeling motivated, maybe you can attempt to write solution and open a PR.

@oleg-codaio
Copy link
Author

Yup! I'm going to take a stab at it -- just wanted to open an issue, first.

@oleg-codaio
Copy link
Author

Ok, I gave it a shot: #793.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants