Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiesce test failing for pre-squid #975

Open
phlogistonjohn opened this issue Mar 23, 2024 · 2 comments
Open

Quiesce test failing for pre-squid #975

phlogistonjohn opened this issue Mar 23, 2024 · 2 comments

Comments

@phlogistonjohn
Copy link
Collaborator

Possibly due to the new feature being backported to squid branch:

 === RUN   TestFSQuiesce
    fs_quiesce_reef_test.go:22: 
        	Error Trace:	/go/src/github.com/ceph/go-ceph/cephfs/admin/fs_quiesce_reef_test.go:22
        	Error:      	Expected nil, but got: &admin.FSQuiesceInfo{Epoch:5, SetVersion:1, Sets:map[string]admin.QuiesceInfo{"ac47ac80":admin.QuiesceInfo{Version:1, AgeRef:0, State:admin.QuiesceState{Name:"TIMEDOUT", Age:0}, Timeout:0, Expiration:0, Members:map[string]admin.QuiesceInfoMember{"file:/volumes/_nogroup/quiesceMe/bf7b4f2b-e605-40f0-8103-4b7f692440ad":admin.QuiesceInfoMember{Excluded:false, State:admin.QuiesceState{Name:"QUIESCING", Age:0}}}}}}
        	Test:       	TestFSQuiesce
    fs_quiesce_reef_test.go:24: 
        	Error Trace:	/go/src/github.com/ceph/go-ceph/cephfs/admin/fs_quiesce_reef_test.go:24
        	Error:      	Should be true
        	Test:       	TestFSQuiesce
--- FAIL: TestFSQuiesce (0.09s)
=== RUN   TestServerSentinel

https://github.com/ceph/go-ceph/actions/runs/8398382664/job/23003150402

@phlogistonjohn
Copy link
Collaborator Author

cc: @manishym @nixpanic @anoopcs9

@anoopcs9
Copy link
Collaborator

We all knew this was coming and that's exactly why I requested for an issue early on to track the changes required with the build tags for 2 variants of test files(fs_quiesce_test.go and fs_quiesce_reef_test.go).

Let's keep the issue open until squid release is out with the feature and corresponding CI job is enabled for go-ceph.

Till then we could have the following change in build tags:

index 5a1075c..73e28ff 100644
--- a/cephfs/admin/fs_quiesce_reef_test.go
+++ b/cephfs/admin/fs_quiesce_reef_test.go
@@ -1,4 +1,4 @@
-//go:build (nautilus || octopus || pacific || quincy || reef || squid || ceph_pre_squid) && ceph_preview
+//go:build (nautilus || octopus || pacific || quincy || reef) && ceph_preview
 
 package admin
 
diff --git a/cephfs/admin/fs_quiesce_test.go b/cephfs/admin/fs_quiesce_test.go
index db2d94d..4aa4b05 100644
--- a/cephfs/admin/fs_quiesce_test.go
+++ b/cephfs/admin/fs_quiesce_test.go
@@ -1,4 +1,4 @@
-//go:build !(nautilus || octopus || pacific || quincy || reef || squid || ceph_pre_squid) && ceph_preview
+//go:build !(nautilus || octopus || pacific || quincy || reef) && ceph_preview
 
 package admin

I would also suggest a change in name for fs_quiesce_reef_test.go as it is applicable for any version prior to squid(upcoming).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants