Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing "is" with "==" in test_headers.py #427

Open
achintya-7 opened this issue Jan 13, 2022 · 0 comments
Open

Replacing "is" with "==" in test_headers.py #427

achintya-7 opened this issue Jan 13, 2022 · 0 comments

Comments

@achintya-7
Copy link

Python will throw a syntax warning when a comparison is made between String using 'is' keyword. It is better to change the 'is' keyword with '==' for comparisons of String.

https://github.com/ceph/s3-tests/blob/master/s3tests/functional/test_headers.py
In the given file, there are three instances of this problem. There is a case of having a similarity of code in all the files of an Open Source project but the '==' keyword is used in a lot of languages and is a norm.

I can make a PR correcting this simple issue if a maintainer approves of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant