Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly faulty test_bucket_create_exists test #465

Open
tangledbytes opened this issue Aug 1, 2022 · 2 comments
Open

Possibly faulty test_bucket_create_exists test #465

tangledbytes opened this issue Aug 1, 2022 · 2 comments

Comments

@tangledbytes
Copy link

Could it be possible that the test test_bucket_create_exists faulty because this https://github.com/ceph/s3-tests/blob/master/s3tests_boto3/functional/test_s3.py#L4419-L4420 should rather look like

-        eq(e.status, 409)
+        eq(status, 409)
-        eq(e.error_code, 'BucketAlreadyOwnedByYou')
+        eq(error_code, 'BucketAlreadyOwnedByYou')

In case the above is true, please let me know. I can create a PR with the fix.

@shirady
Copy link

shirady commented Nov 28, 2022

Hi @Utkarsh-pro ,
I agree with your comment.
Please write here if you would like to send a PR or if you would like @TejasC88 to fix it.

@tangledbytes
Copy link
Author

Hello!
I'd create a PR today for the same. Thank you @Shirad, @TejasC88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants