test_bucket_listv2_encoding_basic

[shirady]

Hi,
about test test_bucket_listv2_encoding_basic (full name: s3tests_boto3.functional.test_s3:test_bucket_listv2_encoding_basic)
It is written in the documentation:

If you specify the encoding-type request parameter, Amazon S3 includes this element in the response, and returns encoded key name values in the following response elements:
Delimiter, Prefix, Key, and StartAfter.

-       `eq(response['Delimiter'], '/')`
+       `eq(response['Delimiter'], '%2F')`

-       `eq(prefixes, ['foo%2B1/', 'foo/', 'quux%20ab/'])`
+       `eq(prefixes, ['foo%2B1%2F', 'foo%2F', 'quux%20ab%2F'])`

(the '/' after encoding).

In case the above is true, please let me know. I can create a PR with the fix.

[ChaosBee]

However, '/' is not encoded in a real S3 listing request with encoding

[shirady]

Hi @ChaosBee,
I asked for those changes in order to use the test.
If you can add more details about what you did I checked it with AWS.

[ChaosBee]

@shirady I just made a object-listing-with-encoding request on S3 and S3 gave me the response with "Key" and "Delimiter" encoded. But, this encoding shows me that "/" in "Delimiter" will not be encoded as "%2F", Even if the documentation you mentioned says "encoded key"

[shirady]

That's what I saw when I checked it in the past.
Anyway, @ChaosBee if you can please share the detailed steps on what you did so I'll be able to check it the same way you did it.