Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing workspace dependency breaks external package installs with pnpm #108

Closed
ottodevs opened this issue Sep 22, 2022 · 3 comments
Closed

Comments

@ottodevs
Copy link

ottodevs commented Sep 22, 2022

"dids": "workspace:^3.2.0",

When trying to add did-session as a dependency to any project I get this error:

 ERR_PNPM_NO_MATCHING_VERSION_INSIDE_WORKSPACE  In : No matching version found for dids@^3.3.1 inside the workspace

This error happened while installing the dependencies of did-session@0.1.3

Consider publishing the package with correct version reference instead of workspace:x
it seems this is the version published to npmjs? #107

Maybe it was caused by using an old pnpm version to publish, it seems workspace references are correctly replaced in recent versions? pnpm/pnpm#4348

Note: Downgrading to did-session@0.1.1 fixes the issue (it seems it was introduced yesterday with 0.1.3) but many repos usually have floating versions like ^0.1.1 so this release will break any repository using pnpm if the version is not pinned

cc @zachferland

@zachferland
Copy link
Contributor

thanks @ottodevs, yeah workspaces should resolve when publishing, thinking it is pnpm/node version and issue there, ill look and republish soon

@zachferland
Copy link
Contributor

@ottodevs try installing did-session@0.1.4

@ottodevs
Copy link
Author

@ottodevs try installing did-session@0.1.4

The issue is fixed in did-session@0.1.4

Thank you so much! I think we can close the issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants