Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cerbos Cloud bundle store driver #1530

Merged
merged 1 commit into from Apr 13, 2023

Conversation

charithe
Copy link
Contributor

Introduces a new storage driver that connectes to Cerbos Cloud to
receive optimized policy bundles.

Signed-off-by: Charith Ellawala charith@cerbos.dev

Introduces a new storage driver that connectes to Cerbos Cloud to
receive optimized policy bundles.

Signed-off-by: Charith Ellawala <charith@cerbos.dev>
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1530 (84dc608) into main (df020fb) will decrease coverage by 2.56%.
The diff coverage is 44.72%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
- Coverage   53.94%   51.38%   -2.56%     
==========================================
  Files         122       88      -34     
  Lines       13585    10002    -3583     
==========================================
- Hits         7328     5140    -2188     
+ Misses       5634     4416    -1218     
+ Partials      623      446     -177     
Impacted Files Coverage Δ
internal/namer/namer.go 64.37% <0.00%> (-0.82%) ⬇️
internal/storage/bundle/source_wrappers.go 0.00% <0.00%> (ø)
internal/util/app.go 0.00% <0.00%> (ø)
internal/storage/bundle/store.go 1.61% <1.61%> (ø)
internal/storage/bundle/conf.go 28.57% <28.57%> (ø)
private/verify/verify.go 34.00% <52.63%> (+9.00%) ⬆️
internal/storage/bundle/remote_source.go 57.27% <57.27%> (ø)
internal/storage/bundle/bundle.go 57.51% <57.51%> (ø)
internal/storage/bundle/local_source.go 61.11% <61.11%> (ø)

... and 43 files with indirect coverage changes

Copy link
Contributor

@dbuduev dbuduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻
Except for the removal of the bundle protobuf code, it seems the change is purely incremental, which is awesome.

@charithe charithe merged commit 52f0daf into cerbos:main Apr 13, 2023
19 of 20 checks passed
@charithe charithe deleted the feat/cerbos-cloud-driver branch April 13, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants