chore: Add output support to Playground API #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the `PlaygroundEvaluateResponse` message to avoid repetition of `effectiveDerivedRoles` and `validationErrors`. Add `outputs` to the evaluate response. Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
+ Coverage 53.36% 53.53% +0.16%
==========================================
Files 130 130
Lines 14852 14855 +3
==========================================
+ Hits 7926 7952 +26
+ Misses 6231 6206 -25
- Partials 695 697 +2
|
Sambigeara
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
PlaygroundEvaluateResponsemessage to avoid repetition ofeffectiveDerivedRolesandvalidationErrors.Add
outputsto the evaluate response.Signed-off-by: Charith Ellawala charith@cerbos.dev