Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Disable cache of Go installation for GolangCI #1662

Merged
merged 1 commit into from Jun 22, 2023

Conversation

charithe
Copy link
Contributor

Disable caching in the setup-go step.

Also removes the Go version config line from .golangci.yaml which would
then force golangci-lint to pick the Go version from go.mod.

https://github.com/golangci/golangci-lint/blob/043c368f2d6f5a4f5a46dcd1a14155cbc090ebdd/.golangci.reference.yml#L71-L74

Signed-off-by: Charith Ellawala charith@cerbos.dev

Disable caching in the `setup-go` step.

Also removes the Go version config line from .golangci.yaml which would
then force golangci-lint to pick the Go version from `go.mod`.

https://github.com/golangci/golangci-lint/blob/043c368f2d6f5a4f5a46dcd1a14155cbc090ebdd/.golangci.reference.yml#L71-L74

Signed-off-by: Charith Ellawala <charith@cerbos.dev>
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1662 (497fa40) into main (ad6928b) will increase coverage by 0.18%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
+ Coverage   53.00%   53.19%   +0.18%     
==========================================
  Files         131      131              
  Lines       15303    15303              
==========================================
+ Hits         8112     8140      +28     
+ Misses       6485     6456      -29     
- Partials      706      707       +1     

see 3 files with indirect coverage changes

@oguzhand95 oguzhand95 self-requested a review June 22, 2023 16:02
@charithe charithe merged commit 9454970 into cerbos:main Jun 22, 2023
19 checks passed
@charithe charithe deleted the chore/golangcilint-version branch June 22, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants