fix: Fix overlay e2e test caused by troublesome bitnami postgres image #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Lock <sam@swlock.co.uk>
oguzhand95
previously approved these changes
Jul 5, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1677 +/- ##
==========================================
+ Coverage 53.00% 53.18% +0.18%
==========================================
Files 131 131
Lines 15314 15314
==========================================
+ Hits 8117 8145 +28
+ Misses 6492 6463 -29
- Partials 705 706 +1 |
Signed-off-by: Sam Lock <sam@swlock.co.uk>
Signed-off-by: Sam Lock <sam@swlock.co.uk>
oguzhand95
approved these changes
Jul 5, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to the underlying postgres image used in our e2e overlay test caused some errors related to duplicate namespaces with the
kubectl create namespacecommand - perhaps (and I'm guessing here) due to being unable to teardown the namespace prior to generating it again on the next test. There were a few fixes for bugs appearing around version 12.6.1:bitnami/charts@262f4f1
bitnami/charts@d6234d8
Locking to this image version resolves this for now.