enhancement(helm): Add ability to set clusterIP #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For headless services, `clusterIP` should be set to `None`. Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1707 +/- ##
==========================================
+ Coverage 53.39% 53.56% +0.17%
==========================================
Files 132 132
Lines 15554 15554
==========================================
+ Hits 8305 8332 +27
+ Misses 6527 6498 -29
- Partials 722 724 +2 |
haines
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For headless services,
clusterIPshould be set toNone.Signed-off-by: Charith Ellawala charith@cerbos.dev