Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Evict policies from cache after disable or enable #1711

Merged
merged 1 commit into from Jul 24, 2023

Conversation

oguzhand95
Copy link
Member

@oguzhand95 oguzhand95 commented Jul 24, 2023

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1711 (98758ce) into main (ac28478) will increase coverage by 0.15%.
The diff coverage is 18.18%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
+ Coverage   52.99%   53.15%   +0.15%     
==========================================
  Files         133      133              
  Lines       15710    15710              
==========================================
+ Hits         8325     8350      +25     
+ Misses       6658     6631      -27     
- Partials      727      729       +2     
Impacted Files Coverage Δ
internal/storage/db/internal/db.go 0.00% <0.00%> (ø)
internal/storage/db/internal/tests.go 0.00% <0.00%> (ø)
internal/storage/git/store.go 57.66% <0.00%> (ø)
internal/storage/index/index.go 49.40% <0.00%> (ø)
internal/storage/store.go 20.58% <0.00%> (ø)
internal/compile/manager.go 66.37% <100.00%> (ø)

... and 4 files with indirect coverage changes

@oguzhand95 oguzhand95 marked this pull request as ready for review July 24, 2023 11:01
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
@oguzhand95 oguzhand95 merged commit 91a0d48 into cerbos:main Jul 24, 2023
19 checks passed
@oguzhand95 oguzhand95 deleted the disable branch July 24, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled/enabled policies stays in the cache until the store is reloaded
2 participants