Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mark auxData parameter as optional in OpenAPI spec #1723

Merged
merged 3 commits into from Aug 3, 2023

Conversation

charithe
Copy link
Contributor

@charithe charithe commented Aug 2, 2023

Need to use a custom extension to signal that certain fields should be
omitted from example generation. However, this is still broken because
Rapidoc doesn't handle the case where request parameters are references
to other objects.

Also includes some theming changes to match Cerbos branding.

image

Signed-off-by: Charith Ellawala charith@cerbos.dev

Need to use a custom extension to signal that certain fields should be
omitted from example generation. However, this is still broken because
Rapidoc doesn't handle the case where request parameters are references
to other objects.

Also includes some theming changes to match Cerbos branding.

Signed-off-by: Charith Ellawala <charith@cerbos.dev>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1723 (009b401) into main (6b09c62) will increase coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
+ Coverage   52.97%   53.12%   +0.14%     
==========================================
  Files         133      133              
  Lines       15716    15716              
==========================================
+ Hits         8326     8349      +23     
+ Misses       6662     6637      -25     
- Partials      728      730       +2     

see 5 files with indirect coverage changes

Signed-off-by: Charith Ellawala <charith@cerbos.dev>
@oguzhand95 oguzhand95 self-requested a review August 3, 2023 11:05
Co-authored-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Signed-off-by: Charith Ellawala <charithe@users.noreply.github.com>
@oguzhand95 oguzhand95 self-requested a review August 3, 2023 14:12
@charithe charithe merged commit 690d90a into cerbos:main Aug 3, 2023
19 checks passed
@charithe charithe deleted the chore/openapi branch August 3, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants