chore: Remove coverage badge #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently showing 0% eventhough the actual coverage is 58%. Furthermore, the number doesn't really reflect the quality of the codebase because it's not smart enough to exclude non-critical and untestable code such as test helpers and command line setup code. Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Sambigeara
approved these changes
Sep 18, 2023
|
Oh! I had to do a hard refresh to see 58%. Anyway, it's a fairly meaningless vanity number with a lot of caveats around it so I'll still go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently showing 0% eventhough the actual coverage is 58%.
Furthermore, the number doesn't really reflect the quality of the
codebase because it's not smart enough to exclude non-critical and
untestable code such as test helpers and command line setup code.
Signed-off-by: Charith Ellawala charith@cerbos.dev