Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages when gRPC endpoint doesn't exist #1814

Open
oguzhand95 opened this issue Sep 21, 2023 · 0 comments
Open

Improve error messages when gRPC endpoint doesn't exist #1814

oguzhand95 opened this issue Sep 21, 2023 · 0 comments
Labels
area/api kind/bug Something isn't working

Comments

@oguzhand95
Copy link
Member

oguzhand95 commented Sep 21, 2023

When Admin API is enabled, we register the AdminService to the handler. If it is not enabled, we do not register it.

When the user sends a request to a non-existent RPC, we do some checks to produce an error message. One of these checks is if the endpoint has the prefix /admin, we assume Admin API is not enabled and return this error.
If a new AdminService RPC is introduced in the newer versions of cerbos, and the user tries this RPC in the older version, we still return the same error which states the admin API is disabled while it is not.

@oguzhand95 oguzhand95 added kind/bug Something isn't working area/api labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant