Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better support for OTLP #1886

Merged
merged 4 commits into from Nov 22, 2023
Merged

Conversation

charithe
Copy link
Contributor

Add ability to configure OTLP trace exporters with more options such as the choice of protocols, sampler configuration, TLS settings etc.

As part of this change, the tracing configuration block in the Cerbos configuration file has been completely deprecated with the aim of removing it in the release after next. This is because of the following reasons:

  • Jaeger native protocol is no longer supported by the Otel SDK.
  • The Otel specification defines standard environment variables that can be used to configure OTLP exporters. Trying to replicate all possible configuration options in our configuration would be brittle and just complicate our code and documentation for not much benefit.

Fixes #1784
Part of #341

Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Copy link
Member

@haines haines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@charithe charithe merged commit 1722454 into cerbos:main Nov 22, 2023
30 checks passed
@charithe charithe deleted the feat/otel-migration branch November 22, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change deprecated OTel jaeger exporter
2 participants