Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Copy metadata to runtime policies #1981

Merged
merged 5 commits into from
Feb 9, 2024
Merged

chore: Copy metadata to runtime policies #1981

merged 5 commits into from
Feb 9, 2024
+1,912 −654

Conversation

dbuduev
Copy link
Contributor

@dbuduev dbuduev commented Feb 9, 2024

No description provided.

@dbuduev
proto changes
8ddb971 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
WIP
f80f54c 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
Merge annotations

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
f1dc141 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
linter
f046ffc 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
linter
f573f25 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev dbuduev marked this pull request as ready for review February 9, 2024 06:13
@dbuduev dbuduev requested a review from charithe February 9, 2024 06:13
charithe
charithe reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@charithe charithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use the top-level metadata field of *PolicySet? A policy set is usually just a single policy anyway (except for scoped policies)

@dbuduev
Copy link
Contributor Author

dbuduev commented Feb 9, 2024

*PolicySet corresponds to several policies in the same scope hierarchy. These policies might have their own metadata.
Using single top-level metadata requires merging annotations from all these files.
Is that what you mean?

@charithe charithe changed the title feat: Copy metadata to runtime policies chore: Copy metadata to runtime policies Feb 9, 2024
charithe
charithe approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@charithe charithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see the problem now 👍🏽

@dbuduev dbuduev merged commit c253d87 into cerbos:main Feb 9, 2024
@dbuduev dbuduev deleted the feat/add-metadata-to-runnables branch February 26, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charithe charithe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbuduev @charithe