Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Update to eslint v5 #6

Closed
5 of 9 tasks
bjankord opened this issue Jun 23, 2018 · 5 comments
Closed
5 of 9 tasks

Update to eslint v5 #6

bjankord opened this issue Jun 23, 2018 · 5 comments
Milestone

Comments

@bjankord
Copy link
Contributor

bjankord commented Jun 23, 2018

Issue Description

eslint v5 has been released: https://eslint.org/blog/2018/06/eslint-v5.0.0-released
We should update our peerDep to use v5 and associated dependencies. We'll likely need to wait on our dependencies to release compat versions with v5.

With this we need to check and see if there are eslint v5 compatible releases for the following:

  • "eslint-config-airbnb" (waiting on release, v17 has been released, however I'm not sure if this is compat with eslint 5 - more info here)
  • "eslint-plugin-compat" (Issue logged)
  • "eslint-plugin-import" (eslint v5 support added in v2.13.0)
  • "eslint-plugin-jsx-a11y" (eslint v5 support set to be added in v6.1.0)
  • "eslint-plugin-react" (eslint v5 support added in v7.10.0)

Issue Type

  • New Feature
  • Enhancement
  • Bug
  • Other

Expected Behavior

Config uses eslint v5 and related compatible plugins

@bjankord bjankord added this to the Backlog milestone Jun 28, 2018
@teriu
Copy link

teriu commented Jul 3, 2018

Support for ESLint v5 just dropped in eslint-plugin-jsx-a11y (6.1.0 is out)

@emilyrohrbough
Copy link
Contributor

Thanks @teriu!

@noahbenham
Copy link

Thank you for keeping the ecosystem current. Minor aside, I've added Cerner to Airbnb's In The Wild.

@dv297
Copy link
Contributor

dv297 commented Aug 28, 2018

Looks like the issue linked for eslint-config-airbnb was closed so probably good to go. Also checked the package.json of eslint-config-airbnb, lists || ^5.3.0

https://github.com/airbnb/javascript/blob/eslint-config-airbnb-v17.1.0/packages/eslint-config-airbnb/package.json#L76

@bjankord
Copy link
Contributor Author

Resolved in #10
Forgot to close this via the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants