Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blocking release 1.13] Should DontAllowInsecureCSRUsageDefinition be renamed or replaced with a opt-in flag? #6203

Closed
inteon opened this issue Jul 7, 2023 · 1 comment · Fixed by #6300
Milestone

Comments

@inteon
Copy link
Member

inteon commented Jul 7, 2023

Before we release 1.13, we have should revisit the DontAllowInsecureCSRUsageDefinition feature flags that were added in #6182 and #6199.

Context: #6182 (comment) and #6199 (comment)

We want to consider the following options:

  • replace the feature flag with an opt-in flag --allow-insecure-csr-usage-defintions
  • rename DontAllowInsecureCSRUsageDefinition to DisallowInsecureCSRUsageDefinition

A feature flag makes it easy to remove this option in the future. However, having a feature gate which is immediate GA in the next available version might not feel right either.

@inteon
Copy link
Member Author

inteon commented Aug 25, 2023

In todays stand-up, we agreed that we can continue with a feature gate (which will make it easy to remove this option in the future).
We still have to:

  • rename DontAllowInsecureCSRUsageDefinition to DisallowInsecureCSRUsageDefinition
  • change the feature gate type to Beta instead of GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant