Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] bump go to 1.21.8 #6826

Conversation

jetstack-bot
Copy link
Contributor

This is an automated cherry-pick of #6824

/assign inteon

Upgrade go to 1.21.8: fixes CVE-2024-24783

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2024
@inteon
Copy link
Member

inteon commented Mar 7, 2024

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
@jetstack-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@SgtCoDFish
Copy link
Member

I suggested a few times that we might as well go to 1.22.x for cert-manager 1.12.x because 1.21.x will EOL before the EOL of release-1.12 - by upgrading to 1.21.x we're creating more work for ourselves in the future

Suggesting it once more here

@inteon
Copy link
Member

inteon commented Mar 7, 2024

I suggested a few times that we might as well go to 1.22.x for cert-manager 1.12.x because 1.21.x will EOL before the EOL of release-1.12 - by upgrading to 1.21.x we're creating more work for ourselves in the future

Suggesting it once more here

I decided to use go1.21.8 because we also use that version in cert-manager 1.14 and on master.
I think we should upgrade to go1.22 by backporting the upgrade from master to 1.14, 1.13 and 1.12.
Also, I did not want to "overtake" master and 1.14

@SgtCoDFish
Copy link
Member

Yeah I would've upgraded to 1.22.x on master

I think this approach of doing 1.21.x now and then upgrading later is significantly worse for everyone involved us and users. I've been a broken record about this.

But I've said my piece - I won't block anything over it.

@jetstack-bot jetstack-bot merged commit c47e9fb into cert-manager:release-1.12 Mar 7, 2024
6 checks passed
@inteon
Copy link
Member

inteon commented Mar 8, 2024

/kind cleanup

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants