Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.12] BUGFIX: fix datarace due to registering and reading from scheme #6833

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[release-1.12] BUGFIX: fix datarace due to registering and reading from scheme #6833

merged 1 commit into from
Mar 8, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Mar 7, 2024 •
edited

Manual backport of the fix in #6028.

see #6832

fixes #6822

Kind

/kind bug

Release Note

BUGFIX: fix race condition due to registering and using global runtime.Scheme variables

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/acme Indicates a PR directly modifies the ACME Issuer code area/testing Issues relating to testing labels Mar 7, 2024
@inteon inteon mentioned this pull request Mar 7, 2024
Closed
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2024
@inteon inteon changed the title [release-1.12] create ad-hoc schemes instead of sharing global ones [release-1.12] BUGFIX: fix datarace due to registering and reading from scheme Mar 7, 2024
@inteon
BUGFIX: fix race condition
e0e8a65 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
wallrj
wallrj approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Looks identical to #6832 . Thanks.

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@jetstack-bot jetstack-bot merged commit 6aae5ec into cert-manager:release-1.12 Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inteon @jetstack-bot @wallrj