Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that/why we don't use Helm's CRD installation mechanism #1186

Open
irbekrm opened this issue Feb 17, 2023 · 2 comments
Open

Document that/why we don't use Helm's CRD installation mechanism #1186

irbekrm opened this issue Feb 17, 2023 · 2 comments
Assignees
@hawksight
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@irbekrm
Copy link
Contributor

irbekrm commented Feb 17, 2023

Cert-manager's Helm chart does not use Helm's CRD installation mechanism because it does not allow for CRD update, see https://github.com/helm/community/blob/f9e06c16d89ccea1bea77c01a6a96ae3b309f823/architecture/crds.md

This can cause confusion for folks, see i.e https://kubernetes.slack.com/archives/C4NV3DWUC/p1676635914363249?thread_ts=1676588335.690979&cid=C4NV3DWUC cert-manager/cert-manager#5794

We should document

  • what is the difference (i.e helm show crds doesn't work)
  • why we are doing this
@irbekrm irbekrm added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. labels Feb 17, 2023
@hawksight
Copy link
Member

hawksight commented Jul 19, 2023 •
edited

I think I might have covered this, or at least a good attempt to:

@irbekrm - appreciate your input if I have covered all the main differences

See: #1248

@hawksight
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawksight hawksight

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hawksight @irbekrm