Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Make label heading styles the default #636

Open
anselmbradford opened this issue Oct 5, 2017 · 3 comments
Open

Make label heading styles the default #636

anselmbradford opened this issue Oct 5, 2017 · 3 comments

Comments

@anselmbradford
Copy link
Member

See background in #632 (comment)

Current behavior

  • The majority of the time label headings are used, not plain labels. This means a-label a-label__heading classes are generally needed.

Expected behavior

  • a-label has the label heading styles and a separate a-label__inline class is added that negates the heading styles. a-label__heading is removed.
@jimmynotjim
Copy link
Contributor

@anselmbradford should we add this to the v5 project? It'll require updating markup in a lot of places and probably shouldn't be considered backward compatible.

@anselmbradford
Copy link
Member Author

Added it.

@jimmynotjim
Copy link
Contributor

Scott and I were discussing this today as part of something unrelated and we had a realization, making the heading style the default would mean unsetting all those styles for the inline modifier. Currently, we're only adding styles, not removing them, so it makes sense from that point of view. One solution might be to make an a-inline-label atom just for inline labels. I'll leave it to you all to decide.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants