Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Deprecate accordions #665

Open
anselmbradford opened this issue Oct 19, 2017 · 3 comments
Open

Deprecate accordions #665

anselmbradford opened this issue Oct 19, 2017 · 3 comments

Comments

@anselmbradford
Copy link
Member

Based on recent discussion, single expandables should be deprecated and all expandables should appear inside an expandable-group, even if it's one item. o-expandable likely would be deprecated, and o-expandable-group_item or similar added.

Current behavior

Expected behavior

  • Since expandables and expandabled groups are delivered together, they should be fully merged as one organism.
@anselmbradford
Copy link
Member Author

anselmbradford commented Nov 6, 2017

Proposals going forward:

  • Expandable.js is turned into a group and no expandable ever appears outside of a group, even if there is only one. Vote 🎉 :

  • Expandable.js is broken into ExpandableGroup.js and Expandable.js. ExpandableGroup.js handles accordion behavior. Expandable groups and single expandables may both exist. Vote ❤️

  • Expandable.js has accordion behavior removed and expandable groups disappear. Vote 👍

@cfpb/cfgov-frontends Please vote on one (or if you have a radical 🍣 throw that into the mix and screw up this whole process. Add your vote as an emoji reaction to this comment.

@anselmbradford
Copy link
Member Author

Per chat, going forward I will be pursuing the second option, both ExpandableGroup.js and Expandable.js, and if accordion behavior can be removed, we'll remove ExpandableGroup.js.

@anselmbradford anselmbradford changed the title Deprecate o-expandable Deprecate accordions Nov 17, 2017
marteki added a commit to cfpb/design-manual that referenced this issue Feb 21, 2018
As shared in cfpb/capital-framework#536 and
cfpb/capital-framework#665, we’ve removed the
accordion option from our design patterns. This updates our
documentation to match the implementation guidelines.
@jimmynotjim
Copy link
Contributor

Stories of Accordion's death are greatly exaggerated, tis alive and well and in use at https://www.consumerfinance.gov/owning-a-home/closing-disclosure/. I've fixed the existing bug in cf-expandables and have the updates working in cfpb/consumerfinance.gov#4365

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants