-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A request with an interceptor, which produces an error, makes the code stuck. #2138
Comments
yehorh
added
h: need triage
This issue needs to be categorized
s: bug
Something isn't working
labels
Mar 13, 2024
AlexV525
added
p: dio
Targeting `dio` package
and removed
h: need triage
This issue needs to be categorized
labels
Mar 14, 2024
7 tasks
It seems I have broken the interface contract. The |
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 15, 2024
Resolves #2138 ### New Pull Request Checklist - [x] I have read the [Documentation](https://pub.dev/documentation/dio/latest/) - [x] I have searched for a similar pull request in the [project](https://github.com/cfug/dio/pulls) and found none - [x] I have updated this branch with the latest `main` branch to avoid conflicts (via merge from master or rebase) - [x] I have added the required tests to prove the fix/feature I'm adding - [ ] I have updated the documentation (if necessary) - [x] I have run the tests without failures - [x] I have updated the `CHANGELOG.md` in the corresponding package --------- Signed-off-by: CaiJingLong <cjl_spy@163.com> Co-authored-by: Alex Li <github@alexv525.com>
7 tasks
AlexV525
added a commit
that referenced
this issue
Mar 28, 2024
Reverts #2139 Fixes #2167 Reopen #2138 ### New Pull Request Checklist - [x] I have read the [Documentation](https://pub.dev/documentation/dio/latest/) - [x] I have searched for a similar pull request in the [project](https://github.com/cfug/dio/pulls) and found none - [x] I have updated this branch with the latest `main` branch to avoid conflicts (via merge from master or rebase) - [ ] I have added the required tests to prove the fix/feature I'm adding - [x] I have updated the documentation (if necessary) - [x] I have run the tests without failures - [x] I have updated the `CHANGELOG.md` in the corresponding package ### Additional context and info (if any) Added tests were fake, so they remained effective after the revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Package
dio
Version
5.4.1
Operating-System
Android
Output of
flutter doctor -v
Dart Version
3.3.1
Steps to Reproduce
Here is a minimal example; I can't understand why the error isn't caught in any way, and everything that follows the request never executes.
tried on Android and macOS
Expected Result
Errors from broken requests must be caught.
Actual Result
The program stops when executing a request, and the subsequent code becomes unreachable.
The text was updated successfully, but these errors were encountered: