fix: .instanceof to allow DOM interfaces in IE11
#1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shvaikalesh @lucasfcosta @vieiralucas want to put a second 👍 on this? |
shvaikalesh
reviewed
Jul 24, 2017
lib/chai/core/assertions.js
Outdated
| } catch (err) { | ||
| if (err instanceof TypeError) { | ||
| flagMsg = flagMsg ? flagMsg + ': ' : ''; | ||
| var type = constructor === null ? 'null' : typeof constructor; |
There was a problem hiding this comment.
maybe we can do _.type(constructor) here?
meeber
force-pushed
the
fix-ie11-instanceof
branch
from
d4bb3c7
to
c107abb
Compare
|
@shvaikalesh Updated! |
keithamus
approved these changes
Jul 25, 2017
|
LGTM too! Good job on that commenting explaining this change. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1000