Change assertion subject when using ownProperty

[lo1tuma]

It would be nice if ownProperty changes the assertion subject in the same way as property does.

So you can do the following expectation:

expect(obj).to.have.ownProperty('foo')
  .that.is.a('string');

[keithamus]

Although it is a backwards incompatible change, it could be worthy of adding. I'd like to hear what @logicalparadox has to say on the matter.

Leaving it open for further discussion.

[jasonkarns]

I agree. The lack of symmetry between property and ownProperty is confusing.

[rhbecker]

+1 ... and while on the topic, why not also support an optional second value argument?

[keithamus]

Yup. You are all right. We should:

• - Alter flag('object') to allow chaining, as per @lo1tuma's suggestion
• - Allow a second value argument, as per @rhbecker's suggestion
• - PR these both against the 4.x.x branch, as it will be a breaking change.

PRs are welcome for these features. If you need assistance let me know and I'll detail the steps needed for this.

[lucasfcosta]

I'm planning on sending a PR for this today.
If someone was already working on this please let me know 😃

[sukrosono]

am i correct that this should be close since 641 have been merged?

[keithamus]

#641 was merged into the 4.x.x branch so this one wouldn't be closed by that. I'll close it manually as there is nothing more that needs doing for this issue - we just need to cut a 4.0.0 release soon to release it.

[Noitidart]

Is it possible to make .property not change the target subject?