Shortened check for empty #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daio-io
commented
Jul 24, 2015
Daio-io
commented
- Updated empty based on conversation on issue should undefined be classed as empty in expect empty #472
|
Looks good, thanks @Daveloper87 😄 |
tusbar
added a commit
to tusbar/chai
that referenced
this pull request
Oct 21, 2015
The change introduced in chaijs#499 breaks compatibility with Array-like objects (e.g. mongoose arrays). It should be applied in the next major version. Fix chaijs#537
keithamus
added a commit
that referenced
this pull request
Oct 21, 2015
Revert .empty assertion change from PR #499
lucasfcosta
pushed a commit
to lucasfcosta/chai
that referenced
this pull request
Mar 14, 2016
The change introduced in chaijs#499 breaks compatibility with Array-like objects (e.g. mongoose arrays). It should be applied in the next major version. Fix chaijs#537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.