Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method assertion option #530

Closed
joshperry opened this issue Oct 6, 2015 · 2 comments
Closed

Method assertion option #530

joshperry opened this issue Oct 6, 2015 · 2 comments

Comments

@joshperry
Copy link
Contributor

A while ago I created a monkeypatch for chai called dirty chai. Its purpose is to change the property assertions to method-style assertions. I have users having issues figuring out how to use it properly and would like a drop-in replacement prodatakey/dirty-chai#9.

Wonder if you guys would be amiable to an integration of the patch I do in dirty-chai directly into chai behind a configuration option.

I'd be happy to do the work, just want to see if a patch would be accepted before I work on it.

@keithamus
Copy link
Member

Hey @joshperry thanks for the issue.

If you take a look at our roadmap (#457) the plan is to eventually get to the point where chai has a range of pluggable interfaces which are generated from assertions - including a "jshint friendly" expect/should. I think this would be a better option than monkey-patching, and it'll be better for the assert style interface which doesn't get much love. Some early spitballing was made here but we need to properly bikeshed out a new declarative plugin syntax that gives enough info to interface plugins to do this kind of magic.

I'll close this one, because I think #457 shows the direction I'd rather see out of chai. If you want to discuss the ideas in #457 further, I think we should totally continue that over there.

@joshperry
Copy link
Contributor Author

Sounds good @keithamus! Thanks for the pointers. I'll head over to 457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants