Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure when custom inspect method is used #680

Merged
merged 1 commit into from Apr 18, 2016

Conversation

polomsky
Copy link
Contributor

When custom inspect method is used and this method calls stylize test crashes.
Stylize method is documented for Node.js 4.x and 5.x.

Objects which use custom inspect method for util.inspect in Node.js should not cause test errors.

When custom inspect method is used and this method calls stylize test crashes.
Stylize method is documented for Node.js 4.x and 5.x.
@keithamus
Copy link
Member

LGTM. @lucasfcosta?

@lucasfcosta
Copy link
Member

lucasfcosta commented Apr 18, 2016

LGTM.

I wasn't fully aware of how Node's inspect worked. Just learned reading this.

Nice catch @polomsky!

@lucasfcosta lucasfcosta merged commit d96937a into chaijs:master Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants