"use" doesn't behave as expected as an ES6 named export

[meeber]

The following code throws an error:

import sinonChai from "sinon-chai";
import {expect, use} from "chai";

use(sinonChai);

The reason it throws an error is because the necessary this binding is lost when calling use via the above syntax as opposed to calling it via chai.use(sinonChai).

I'd argue that it's unexpected and undesirable for a singleton module to utilize this in such a way.

One possible solution might be to change use from:

exports.use = function (fn) {
  if (!~used.indexOf(fn)) {
    fn(this, util);
    used.push(fn);
  }

  return this;
};

To:

exports.use = function (fn) {
  if (!~used.indexOf(fn)) {
    fn(exports, util);
    used.push(fn);
  }

  return exports;
};

[lucasfcosta]

Looks good to me.
Since this and exports refer to the same object (which is the chai module which is being exported by this file) I can't see any other side effects for this.
Nice catch 👍

[meeber]

@lucasfcosta Thanks for checking this out. I'll prolly submit a PR after work.