Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .deep.property for deep equality comparisons #758

Merged
merged 3 commits into from Aug 15, 2016

Conversation

meeber
Copy link
Contributor

@meeber meeber commented Jul 26, 2016

Notes:

- Previously, `expect(obj).not.property(name, val)` would throw an Error
if `obj` didn't have a property named `name`. This change causes the
assertion to pass instead.
- assert.propertyNotVal renamed to assert.notPropertyVal
- assert.deepPropertyNotVal renamed to assert.notDeepPropertyVal
- Previously, the `deep` flag had unexpected behavior when used with the
`property` assertion: Instead of switching from strict to deep equality,
it unlocked the ability to use dot and bracket notation when referencing
property names. This behavior now belongs to the new `nested` flag.
- assert.deepProperty renamed to assert.nestedProperty
- assert.notDeepProperty renamed to assert.notNestedProperty
- assert.deepPropertyVal renamed to assert.nestedPropertyVal
- assert.notDeepPropertyVal renamed to assert.notNestedPropertyVal
@keithamus
Copy link
Member

LGTM 👍. @lucasfcosta?

@lucasfcosta
Copy link
Member

lucasfcosta commented Aug 14, 2016

LGTM 👍 too.

Edit: Well, for some unknown reason, LGTM seems to be broken since it's not allowing me to merge this even though I have added a comment including the magical keyword.

@meeber
Copy link
Contributor Author

meeber commented Aug 14, 2016

Let's see if this works: LGTM

Edit: Looks like their website is down.

@lucasfcosta
Copy link
Member

Reposting because LGTM was down before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants