Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto register side effects and Update documentation #872

Merged
merged 3 commits into from Nov 18, 2016
Merged

Auto register side effects and Update documentation #872

merged 3 commits into from Nov 18, 2016

Conversation

inancgumus
Copy link

@inancgumus inancgumus commented Nov 18, 2016 •
edited

An updating pull request for the new comments from the team: #868

There was an earlier commits for this work, then, this is updating it.

@meeber
Copy link
Contributor

meeber commented Nov 18, 2016

Thanks for the PR! Couple nits for consistency:

  • Switch Pre-Native Modules Usage (as local variables) examples to use single quotes instead of double.
  • Add a semicolon to both should() statements.

@inancgumus
Copy link
Author

@meeber Thanks for reviewing. I updated it.

@inancgumus inancgumus mentioned this pull request Nov 18, 2016
Closed
@meeber
Copy link
Contributor

meeber commented Nov 18, 2016

LGTM!

@lucasfcosta
Copy link
Member

LGTM too!

@lucasfcosta lucasfcosta merged commit 5a0aa59 into chaijs:master Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inancgumus @meeber @lucasfcosta