Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.change, .increase, and .decrease wrong assertion type #917

Closed
meeber opened this issue Jan 26, 2017 · 0 comments
Closed

.change, .increase, and .decrease wrong assertion type #917

meeber opened this issue Jan 26, 2017 · 0 comments

Comments

@meeber
Copy link
Contributor

meeber commented Jan 26, 2017

These three assertions are all registered as chainable method assertions despite not having any chainable behavior. It'd be okay for them to be chainable if they had non-specific meaning like "of" and "at", but that's not the case. Therefore, they should be changed to normal method assertions.

I suspect they were registered as chainable method assertions because of their interaction with the by assertion, e.g., expect(targetFn).to.increase(subjectFn).by(2). However, that's still normal method assertion behavior; it'd only be chainable method assertion behavior if the non-invoked property-access version of the assertion had a side-effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant