fix: wrong assertion types #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieiralucas
approved these changes
Feb 1, 2017
BREAKING CHANGE: `.change`, `.increase`, and `.decrease` changed from Chainable Method Assertions to Method Assertions. They don't have any chaining behavior, and there's no generic semantic benefit to chaining them.
meeber
force-pushed
the
fix-assertion-types
branch
from
d75c6c7
to
56a81ea
Compare
|
@vieiralucas Good point! I've updated the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
.change,.increase, and.decreasechanged fromChainable Method Assertions to Method Assertions. They don't have any
chaining behavior, and there's no generic semantic benefit to chaining
them.
Fixes #917
Note: If this is merged, #920 needs to be updated in order to remove verbiage about chaining behavior.