fix: PhantomJS 1.x incompatibility #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
meeber
commented
May 7, 2017
•
meeber
commented
- Addresses Plugin issues with Chai v4 #890 (comment)
- Although I'm not crazy about adding a workaround in Chai for a 3rd party library, in this particular case it feels like a low-cost solution to allow Chai to continue supporting PhantomJS 1.x until plugins have had a chance to upgrade.
|
LGTM 👍. I'll leave the merge for another reviewer (+ @lucasfcosta, @shvaikalesh, @vieiralucas) |
keithamus
approved these changes
May 8, 2017
|
LGTM. I don't think this will ever happen in any other environment, but does make things safer anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.