Add a missing var keyword found by lgtm.com #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this code path,
htmlis defined as a global variable rather than a local one, this is probably not what was intended.This problem was found by lgtm.com: https://lgtm.com/projects/g/chaijs/chai/alerts/
chai is actually in pretty good shape as far as lgtm's default selection of javascript queries are concerned, in fact this is currently the only result that is found. But perhaps it would be of interest to enable PR integration for chai to prevent problems appearing that lgtm's current queries find? You can do this from here: https://lgtm.com/projects/g/chaijs/chai/ci/ And read more about it here: https://lgtm.com/docs/lgtm/config/pr-integration
Full Disclosure: I'm a core developer at lgtm.com